Hi all and merry Christmas to all!
I have a question and maybe, if it's possible, a bios mod request.
I have a Asus Z9PE-D8 WS mainboard, with linux installed on it (I tried different distributions, ubuntu, artix, arch, manjaro): from about 7 months I was trying to fix or find a workaround for an issue that was really struggling me (that was showing in all distributions, even with the usb bootable installer): sometimes (about 30-50% of the times) the os hangs in S5 and the workstation doesn't complete the shutdown.
I opened different bugs at bugtrackers, for example (I'm not allowed to write links):
at the kernel bugtracker:
show_bug.cgi?id=210689

and
at the ubuntu/launchpad bugtracker:
ubuntu/+source/linux/+bug/1909115

Finally I extracted the DSDT, fixed the error and modified the _PTS method logic, to include a "do nothing" if Arg0=0x05 (S5 state): after applying this modification I noticed that this was advice in the "hackintosh" world, as a workaround/fix for shutdown hang for asus mainboards.

More into details, the original code is:

    Method (_PTS, 1, NotSerialized) // _PTS: Prepare To Sleep
    {
        If (((Arg0 == 0x04) && (OSFL () == 0x02)))
        {
            Sleep (0x0BB8)
        }
 
        PTS (Arg0)
        DBG8 = Arg0
        WAKP [Zero] = Zero
        WAKP [One] = Zero
        WSSB = ASSB /* \ASSB */
        WOTB = AOTB /* \AOTB */
        WAXB = AAXB /* \AAXB */
        ASSB = Arg0
        AOTB = OSFL ()
        AAXB = Zero
        \_SB.SLPS = One
    }
 

Modified to:

    Method (_PTS, 1, NotSerialized)
    {
       If (LEqual (Arg0, 0x05)) {}
       Else
       {
           Store (Arg0, DBG8)
           If (LAnd (LEqual (Arg0, 0x04), LEqual (OSFL (), 0x02)))
           {
               Sleep (0x0BB8)
           }
 
           PTS (Arg0)
           Store (Zero, Index (WAKP, Zero))
           Store (Zero, Index (WAKP, One))
           Store (ASSB, WSSB)
           Store (AOTB, WOTB)
           Store (AAXB, WAXB)
           Store (Arg0, ASSB)
           Store (OSFL (), AOTB)
           Store (Zero, AAXB)
           Store (One, \_SB.SLPS)
       }
    }
 

After applying the dsdt override the system is able to complete the shutdowns in 100% of the cases.
I hope this can be fixed kernel side, but I was thinking if it could be possible to modify the bios with this patch in the acpi tables and flash it.

I'm attaching my original dsdt.dsl (no errors fixed) and the fixed dsdt.dsl (errors fixed+shutdown patch)--->rename extensions from .txt to .dsl

Ok, I read something about this, I think I'm quite closed to the solution, but still need help.
What I did (I mainly followed @CodeRush advices):

1- downloaded original bios from asus: Z9PE-D8 WS, v.5802
2- Downloaded UEFITool, v. 0.28 (not alpha/NE version, so I can replace/rebuild)
3- I have my patched DSDT.aml: this was compiled on mac os with maciasl 1.5.9: it uses iasl v. 20200925
4- I tested my patched DSDT by injecting at boot time: it works
5- I run UEFITool, highlighted the PE32+ submenu into the AmiBoardInfo and extracted the body as .bin
6- Opened the extracted .bin and the patched DSDT.aml in a hex editor
7- Replaced in the hex editor the DSDT part inside the .bin with that of the patched DSDT.aml (and filled at the end of the DSDT part with FF FF....till reaching the same size of the original)
8- In UEFITool, with the original asus bios opened (.cap), replaced body of PE32+ with the patched one (checked again that remove and replace had the same size)
9- Saved the patched bios image (.cap)

Part 2 - Flashing
I used Afuwin to flash the chip (I downloaded v.3.05.04 with /GAN)

1- Flashed the original asus bios: afuwinx64.exe <NAME OF THE ORIGINAL BIOS>.CAP
2- Opened the .cap file of the patched bios in UEFITool
3- Right click on AMI Aptio capsule, then extract body, and save as .ROM (size was -2kb compared to original .cap, but this was expected)
4- Flashed the modded .rom: afuwinx64.exe <NAME OF THE MODDED BIOS>.ROM /GAN

No errors, but on reboot, only a black screen :( (...and q-code 06)
Luckily I have a spare chip and with a hot swap I was able to flash again the original bios.

Did I miss anything?Checksum?
Could it depend on the iasl version?Can I use a newer iasl (acpi specification 6.3, for example) to fix errors on a 2.0a acpi motherboard?

Thank you

No way, I tried with UEFITool, PhoenixTool and MMTool, all resulted in black screen and qcode 06.
Following the modded bios image with UEFITool 0.28

If anybody can explain me what's wrong with the modded image I would be greatful.
Here the original cap file:
Edited: see post #6

Here the modded rom (image packed as described in post #2, with the exception that I made the DSDT patch the same size as the original and I used iasl 20051117 to compile the DSDT (should be the same version used to compile the original DSDT))<--archive contains: MOD rom, DSDT-patch2.aml replaced in AmiBoardInfo PE32 image and DSDT-patch2.dsl (source code):
Edited: see post #6

The only thing I noticed is that the compressed section into AmiBoardInfo is different if compared to the original bios.

@ghost82 - Don't use UEFITool 28.0 for this, use 25.0, I assume padding is being added or removed on rebuild
Don't use AFU, use flash programmer if you have, otherwise you will never know if using OLD AFU /GAN is part of the issue here

I can't comment or help any with the actual edit your doing, all my reply is simply based on rebuilding mod BIOS / flashing etc.
I see this model does not have flashback So if you do not have programmer, and nothing helps, you need to get programmer before you are sure which is failing - your edit, or the AFU /GAN flashing.

Please upload that file to another upload host so I can check your edit, I can't download that because it's blocked as a virus by Eset (it may be the package too, not just the site, not sure)
If I can't download from other source, then upload for me ONLY the mod BIOS in a zip
Upload to one of these, thanks
tinyupload.com
https://ufile.io/

Thank you very much @Lost_N_BIOS !
Ok for UEFITool 25, I will try and see if there are any difference. <--- Just tried, rom files are identical :( (0.28 - 0.25 versions)
Yes, I was thinking about AFU not being the right tool to flash, I will buy the programmer in any case, I was just thinking for somebody to check the rom file to see if there are some macro errors, sorry but I'm really a novice :P
Sorry for the links, I can ensure the files are 100% safe, I will edit my post above soon, here new links (PS I think it's workupload site being flagged as malicious by Eset):
Modded rom:
https://ufile.io/3ujq95h8

Original rom:
https://ufile.io/2yadqxo1

Yes my board has no flashback, luckily the chip is removable, and I used hot swap to restore original bios (yes, I know....very risky!!)

You're welcome! Make sure you use 25.0, not 25.1 or other. I do not need original rom, I have the stock BIOS already.
Hot swap is OK, do while in windows or while inside EZ Flash in BIOS.

You need CH341A + U Type Flat IC extractor, if you don't already have an extractor (save your BIOS legs from future accident, they bend SUPER easy)
Yes, file is OK, it was that site you uploaded to

I checked your mod, and as suspected, padding issue (added in this case) directly below 472A583E-70CF-465A-BB77-53ADFCDB5883 padding file is added vs stock
Rest of the edit I can't comment on, sorry, I know nothing about editing DSDT stuff.

So, once you have programmer, and use UEFITool 25.0 so you don't have that added padding (or MMTool 5.02 may work too, I did not check), and it still fails after dump/edit/program, then the issue is in the actual edit or replacing back in that table etc.

Zitat von Lost_N_BIOS im Beitrag #7

---

You're welcome! Make sure you use 25.0

I checked your mod, and as suspected, padding issue (added in this case) directly below 472A583E-70CF-465A-BB77-53ADFCDB5883 padding file is added vs stock
Rest of the edit I can't comment on, sorry, I know nothing about editing DSDT stuff.

So, once you have programmer, and use UEFITool 25.0 so you don't have that added padding (or MMTool 5.02 may work too, I did not check), and it still fails after dump/edit/program, then the issue is in the actual edit or replacing back in that table etc.

---

I don't see anything you "Filled with FF"?? Where is that?
Yes, it may be that 25.0 adds padding in this one too, sometimes both new and old do it, in that cause you should use MMTool instead.
I see the padding added just below the GUID I mentioned above (Search via GUID in UEFITool with BIOS open side by side, you will see) It's just below OCMR_DXE

I will check now and see which MMTool will do this without adding that padding, or how to make 25.0 do it without adding the padding (ie extract already modified/inserted module as-is, and replace entire module with UEFITool 25.0 and see if same happens)

Zitat von Lost_N_BIOS im Beitrag #9

---

I don't see anything you "Filled with FF"?? Where is that?
Yes, it may be that 25.0 adds padding in this one too, sometimes both new and old do it, in that cause you should use MMTool instead.
I see the padding added just below the GUID I mentioned above (Search via GUID in UEFITool with BIOS open side by side, you will see)

I will check now and see which MMTool will do this without adding that padding, or how to make 25.0 do it without adding the padding (ie extract already modified/inserted module as-is, and replace entire module with UEFITool 25.0 and see if same happens)

---

OK, thanks! See my edit above, in case you still can't find the padding I mentioned

Send me an AFU Dumped BIOS, so I can see, it may be this padding is there in actual BIOS, but not in stock (sometimes this happens too, and it may be OK)
All versions of MMTool add the padding too! Yes, you can't remove it. To work around this will take me some time, it's a delicate dance . I will make you BIOS for test without this, happening, please wait patiently.
But, let me check your AFU dump before I spend the time doing that if it's not necessary.

@ghost82 - see edit above

Zitat von Lost_N_BIOS im Beitrag #9

---

ie extract already modified/inserted module as-is, and replace entire module with UEFITool 25.0 and see if same happens

---

@ghost82 - Yes, please see my edit above, thanks

Thank you again!
AFU backup:
https://ufile.io/rpty2v8b

You're welcome! Thanks, this confirms the padding is no there on chip either. This may not be the issue with your mod BIOS, but I would start suspicion here, and then if working past that fails, it's either your actual edit or the AFU Flash
Give me some time, I will redo your edit with stock BIOS and your modified AMIBoardInfo Module, without the padding being added in there on rebuild.